Topic Display order fout in code

[Cheeta]

Code: Selecteer alles

//-- mod : topic display order ---------------------------------------------------------------------
//-- add
$forum_display_sort_list = get_forum_display_sort_option($forum_display_sort, 'list', 'sort');

$forum_display_order_list = get_forum_display_sort_option($forum_display_order, 'list', 'order');
//-- fin mod : topic display order -----------------------------------------------------------------

Kan iemand mij hier de fout in vertellen kan namelijk zelf niks vinden!!

tnx

mzzl 8)

[Cheeta]

Ik heb inmiddels wel de functies met de hand werkend gekregen. Maar wil nu nog in het admin paneel dat ik ze daar kan voor instellen.

Dit stukje komt uit admin/edit_forums.php (topic display order mod)

mzzl 8)

[WebSiteNet]

• Welke mod?
• Waar hoe en wat?
• Heb je wat gewijzigd?
• Welke fout meldingen krijg je?

Hoe kunnen we wat mee .

[Cheeta]

Topic Display Order (zie naam)
admin/admin_forums.php
Ja deze mod geinstalleerd
Parse error op line 323 (eerste lijn in bovenstaande code)

mzzl 8)

[WebSiteNet]

ok, wat staat er voor die lijn? Meestal worden foutmeldingen veroorzaakt door de lijn erboven.

[Cheeta]

Code: Selecteer alles

// These two options ($lang['Status_unlocked'] and $lang['Status_locked']) seem to be missing from
// the language files.
$lang['Status_unlocked'] = isset($lang['Status_unlocked']) ? $lang['Status_unlocked'] : 'Unlocked';
$lang['Status_locked'] = isset($lang['Status_locked']) ? $lang['Status_locked'] : 'Locked';
$statuslist = "<option value=\"" . FORUM_UNLOCKED . "\" $forumunlocked>" . $lang['Status_unlocked'] . "</option>\n";
$statuslist .= "<option value=\"" . FORUM_LOCKED . "\" $forumlocked>" . $lang['Status_locked'] . "</option>\n"; 
$template->set_filenames(array(
"body" => "admin/forum_edit_body.tpl")

Dit staat er

[WebSiteNet]

Daar moet dit nog achter:

Code: Selecteer alles

);

[Cheeta]

Tnx dat was het!!

Die commando stond verkeerd (4 rijen lager)

mzzl 8)

[MeDieViL]

ik heb die mod ook geinstalleert
maar ik zie nergens de sort opties!!!

[WebSiteNet]

Kijk dan eens aan de onderkant van viewforum. Wel wat instellen in het acp geloof ik.

[MeDieViL]

Kijk dan eens aan de onderkant van viewforum. Wel wat instellen in het acp geloof ik.

ik zie alleen deze drop down box
"Display topics from previous: "

in het acp kan ik wel de standaard order veranderen, maar de opties op viewforum krij gik ni tevoorschijn....
dit is de rede volges mij:

Code: Selecteer alles

Could not obtain topic information

DEBUG MODE

SQL Error : 1064 You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ' t.topic_last_post_id DESC LIMIT 0, 30' at line 10

SELECT t.*, u.username, u.user_id, u2.username as user2, u2.user_id as id2, p.post_username, p2.post_username AS post_username2, p2.post_time FROM phpbb_topics t, phpbb_users u, phpbb_posts p, phpbb_posts p2, phpbb_users u2 WHERE t.forum_id = 1 AND t.topic_poster = u.user_id AND p.post_id = t.topic_first_post_id AND p2.post_id = t.topic_last_post_id AND u2.user_id = p2.poster_id AND (t.topic_type <> 2 AND t.topic_type <> 3) ORDER BY t.topic_type DESC, , t.topic_last_post_id DESC LIMIT 0, 30

Line : 488
File : f:\program files\easyphp1-7\www\phpbb2\viewforum.php

zo een error had ik viewforum, die heb ik kunne fixe door dit toe te voegen
$sort_method = get_forum_display_sort_option($sort_value, 'field', 'sort');
$order_method = get_forum_display_sort_option($order_value, 'field', 'order');

deze line toegevoegd

if ( $sort_method == "" ) { $sort_method = "t.topic_last_post_id"; $order_method = "DESC"; }


die had de error gestopt, maar de sort opties vertschijnen nu niet

[Cheeta]

Als je ff geduld hebt zet ik wel een premodded file van viewforum.php op mijn server!

http://xplosiv-hosting.com/~veugerwe/viewforum.zip

mzzl 8)

[MeDieViL]

thx, maar dan ga ik wel problemen krijgen met mn andere mods

van die error ben ik nu af, alleen zie ik dat dropdown box nergens voor de sorting

[MeDieViL]

wiet iemand wat er fout is??

[MeDieViL]

ik denk dat ik weet waar de fout is

Code: Selecteer alles

$sql = "SELECT t.*, u.username, u.user_id, u2.username as user2, u2.user_id as id2, p.post_time, p.post_username
	FROM " . TOPICS_TABLE . " t, " . USERS_TABLE . " u, " . POSTS_TABLE . " p, " . USERS_TABLE . " u2
	WHERE (t.forum_id = $forum_id 
	" . ( (intval($board_config['announcement_display_forum']) == 0) ? " OR t.topic_type = " . POST_GLOBAL_ANNOUNCE : '' ) . ")

		AND t.topic_poster = u.user_id
		AND p.post_id = t.topic_last_post_id
		AND p.poster_id = u2.user_id
		AND (t.topic_type = " . POST_ANNOUNCE . " OR t.topic_type = " . POST_GLOBAL_ANNOUNCE . ") 
	ORDER BY t.topic_type DESC, t.topic_last_post_id DESC ";

Code: Selecteer alles

$sql = "SELECT t.*, u.username, u.user_id, u2.username as user2, u2.user_id as id2, p.post_username, p2.post_username AS post_username2, p2.post_time 
	FROM " . TOPICS_TABLE . " t, " . USERS_TABLE . " u, " . POSTS_TABLE . " p, " . POSTS_TABLE . " p2, " . USERS_TABLE . " u2
	WHERE t.forum_id = $forum_id
		AND t.topic_poster = u.user_id
		AND p.post_id = t.topic_first_post_id
		AND p2.post_id = t.topic_last_post_id
		AND u2.user_id = p2.poster_id 
		AND t.topic_type <> " . POST_ANNOUNCE . " 
		AND t.topic_type <> " . POST_GLOBAL_ANNOUNCE . "
		$limit_topics_time
	ORDER BY t.topic_type DESC, $sort_method $order_method
	, t.topic_status ASC, t.topic_last_post_id DESC 
	LIMIT $start, ".$board_config['topics_per_page'];

#
#-----[ FIND ]------------------------------------------------
# this is a partial search : the full lines are longer
$sql = "SELECT t.*,
FROM " . TOPICS_TABLE . "
WHERE t.forum_id =
AND t.topic_poster =
AND p.post_id =
AND p2.post_id =
AND u2.user_id =
AND t.topic_type <> " . POST_ANNOUNCE . "
$limit_topics_time
ORDER BY t.topic_type DESC, t.topic_last_post_id DESC
LIMIT
#
#-----[ BEFORE, ADD ]-----------------------------------------
#
//-- mod : topic display order ---------------------------------------------------------------------
// here we added
// , $sort_method $order_method
//-- modify
#
#-----[ IN-LINE FIND ]----------------------------------------
#
t.topic_type DESC
#
#-----[ IN-LINE AFTER, ADD ]----------------------------------
#
, $sort_method $order_method
#
#-----[ AFTER, ADD ]------------------------------------------
#
//-- fin mod : topic display order -----------------------------------------------------------------
#

bij welke hoort dat nu, de eerste of de 2de???
ik had het eerst gedan op die 2de alleen, en daarom zijn die 2 drop down boxes er niet?

[Cheeta]

Code: Selecteer alles

SQL Error : 1110 Column 'forum_display_order' specified twice

INSERT INTO phpbb_forums (forum_id, forum_name, cat_id, forum_desc, forum_order, forum_status, prune_enable, auth_view, forum_display_sort, forum_display_order, auth_read, forum_display_sort, forum_display_order, auth_post, forum_display_sort, forum_display_order, auth_reply, forum_display_sort, forum_display_order, auth_edit, forum_display_sort, forum_display_order, auth_delete, forum_display_sort, forum_display_order, auth_sticky, forum_display_sort, forum_display_order, auth_announce, forum_display_sort, forum_display_order, auth_vote, forum_display_sort, forum_display_order, auth_pollcreate, forum_display_sort, forum_display_order) VALUES ('12', 'Smoel van het jaar', 1, 'Nomineer hier iedereen die kans maakt op de Smoel van het jaar bokaal!', 40, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 1, 0, 0, 3, 0, 0, 3, 0, 0, 1, 0, 0, 1, 0, 0)

Line : 434
File : /home/veugerwe/public_html/admin/admin_forums.php

Ik heb zelf nu deze fout bij het aanmaken van een nieuw forum!!
Iemand tips om na te kijken???

mzzl 8)

[WebSiteNet]

Je hebt hem 2 keer gemod.

[MeDieViL]

en mijn probleem???

[Cheeta]

Je hebt hem 2 keer gemod.

weet wel cker van niet

maar kom de foutmelding die die geeft 5x tegen!
forum_display_order staat er 5x in

mzzl 8)

[Cheeta]

heb het al gevonden

Code: Selecteer alles

//-- mod : topic display order ---------------------------------------------------------------------
//-- add
			$field_sql .= ', forum_display_sort';
			$value_sql .= ', ' . intval($HTTP_POST_VARS['forum_display_sort']);
			$field_sql .= ', forum_display_order';
			$value_sql .= ', ' . intval($HTTP_POST_VARS['forum_display_order']);
//-- fin mod : topic display order -----------------------------------------------------------------

stond er teveel in (vaag) maar wel op 2 verschillende manieren vermeld!

mzzl 8)