Minimum And Maximum Post Message Length probleempje

Muiter · Bericht door **Muiter** » 28 mar 2005, 11:31

## MOD Title: Minimum And Maximum Post Message Length 
## MOD Author: Leuchte < mail@leuchte.net > http://www.leuchte.net 
## MOD Description: This Mod allows you to require a minimum and maximum amount of characters in a post.
## MOD Version: 1.0.1

Ik ben deze mod aan het testen en hij werkt goed maar als er geen bericht wordt bericht getypt kan het bericht toch geplaatst worden.
Op welke manier moet ik dit aanpassen zodat dat ook werkt?

Code: Selecteer alles

#  
#-----[ OPEN ]------------------------------------------ 
# 
includes/functions_post.php

# 
#-----[ FIND ]------------------------------------------ 
#
// Check message
	if (!empty($message))
	{

# 
#-----[ REPLACE WITH ]------------------------------------------ 
#
// Check message
// $mode == 'editpost' added for Min-Maxlength Mod
	if (!empty($message) || $mode == 'editpost')
	{ 
  $message = trim($message);
  if ( (strlen ($message) > $board_config['message_maxlength']) && ($board_config['message_maxlength'] > 0) )
        {
            $message_too_long = sprintf($lang['Message_Maxlength_error'], $board_config['message_maxlength']);
            $error_msg .= (!empty($error_msg)) ? '<br />' . $message_too_long : $message_too_long;
        }
  if ( (strlen ($message) < $board_config['message_minlength']) && ($board_config['message_minlength'] > 0) )
        {
            $message_too_short = sprintf($lang['Message_Minlength_error'], $board_config['message_minlength']);
            $error_msg .= (!empty($error_msg)) ? '<br />' . $message_too_short : $message_too_short;
        }

Alpha · Bericht door **Alpha** » 28 mar 2005, 11:43

als er geen bericht wordt bericht getypt kan het bericht toch geplaatst worden.

en daar bedoel je mee

Muiter · Bericht door **Muiter** » 28 mar 2005, 12:12

Alpha schreef:
als er geen bericht wordt bericht getypt kan het bericht toch geplaatst worden.
en daar bedoel je mee

Dat het minium aantal karakters alleen werkt als er minimaal 1 karakter is getypt.

Luuk · Bericht door **Luuk** » 28 mar 2005, 18:19

Als je niets intypt dan krijg je zowiezo al een melding.

Muiter · Bericht door **Muiter** » 28 mar 2005, 18:21

Luuk schreef:Als je niets intypt dan krijg je zowiezo al een melding.

Nu niet meer dus. Dat is juist het probleem.

Luuk · Bericht door **Luuk** » 28 mar 2005, 18:24

Dan moet er iets aan de JS worden aangepast in posting_body.tpl, je krijgt namelijk een JS alert en dat wordt niet in een php bestand geregeld.

Muiter · Bericht door **Muiter** » 22 mei 2005, 19:25

Luuk schreef:Dan moet er iets aan de JS worden aangepast in posting_body.tpl, je krijgt namelijk een JS alert en dat wordt niet in een php bestand geregeld.

Het gaat volgens mij hierom:

Code: Selecteer alles

# 
#-----[ OPEN ]------------------------------------------ 
# 
includes/functions_post.php

# 
#-----[ FIND ]------------------------------------------ 
#
// Check message
	if (!empty($message))
	{

# 
#-----[ REPLACE WITH ]------------------------------------------ 
#
// Check message
// $mode == 'editpost' added for Min-Maxlength Mod
	if (!empty($message) || $mode == 'editpost')
	{ 
  $message = trim($message);
  if ( (strlen ($message) > $board_config['message_maxlength']) && ($board_config['message_maxlength'] > 0) )
        {
            $message_too_long = sprintf($lang['Message_Maxlength_error'], $board_config['message_maxlength']);
            $error_msg .= (!empty($error_msg)) ? '<br />' . $message_too_long : $message_too_long;
        }
  if ( (strlen ($message) < $board_config['message_minlength']) && ($board_config['message_minlength'] > 0) )
        {
            $message_too_short = sprintf($lang['Message_Minlength_error'], $board_config['message_minlength']);
            $error_msg .= (!empty($error_msg)) ? '<br />' . $message_too_short : $message_too_short;
        }

Luuk · Bericht door **Luuk** » 22 mei 2005, 20:06

Dan zou je een pagina moeten krijgen, normaal als je niets invult krijg je een JS alert. Of is die bij jouw soms weg uit posting_body.tpl?

Muiter · Bericht door **Muiter** » 22 mei 2005, 20:14

Luuk schreef:Dan zou je een pagina moeten krijgen, normaal als je niets invult krijg je een JS alert. Of is die bij jouw soms weg uit posting_body.tpl?

In het bestand posting_body.tpl heb ik niets veranderd.

Code: Selecteer alles

# 
#-----[ OPEN ]------------------------------------------ 
# 
language/lang_english/lang_admin.php 

# 
#-----[ FIND ]------------------------------------------ 
# 
//
// That's all Folks!

# 
#-----[ BEFORE, ADD ]------------------------------------------ 
# 
$lang['Message_Minlength'] = 'Minimum Postlength';
$lang['Message_Maxlength'] = 'Maximum Postlength';
$lang['Message_Minlength_Explain'] = 'Set the minimum length of messages being posted.<br>Set to 0 for no limit.';
$lang['Message_Maxlength_Explain'] = 'Set the maximum length of messages being posted.<br>Set to 0 for no limit.';

# 
#-----[ OPEN ]------------------------------------------ 
# 
language/lang_english/lang_main.php 

# 
#-----[ FIND ]------------------------------------------ 
# 
$lang['Empty_message'] = 'You must enter a message when posting.';

# 
#-----[ REPLACE WITH ]------------------------------------------ 
# 
//$lang['Empty_message'] = 'You must enter a message when posting.'; 
$lang['Message_Minlength_error'] = 'Your message must have %d characters at least.<br>Your message is too short.';
$lang['Message_Maxlength_error'] = 'The message size is restricted to %d characters.<br>Your message is too long.';

# 
#-----[ OPEN ]------------------------------------------ 
# 
admin/admin_board.php

# 
#-----[ FIND ]------------------------------------------ 
# 
"L_FLOOD_INTERVAL_EXPLAIN" => $lang['Flood_Interval_explain'],

# 
#-----[ AFTER, ADD ]------------------------------------------ 
# 
  "L_MESSAGE_MINLENGTH" => $lang['Message_Minlength'],
  "L_MESSAGE_MAXLENGTH" => $lang['Message_Maxlength'],
  "L_MESSAGE_MINLENGTH_EXPLAIN" => $lang['Message_Minlength_Explain'],
  "L_MESSAGE_MAXLENGTH_EXPLAIN" => $lang['Message_Maxlength_Explain'],

# 
#-----[ FIND ]------------------------------------------ 
# 
"FLOOD_INTERVAL" => $new['flood_interval'],

# 
#-----[ AFTER, ADD ]------------------------------------------ 
# 
  "MESSAGE_MINLENGTH" => $new['message_minlength'],
  "MESSAGE_MAXLENGTH" => $new['message_maxlength'],

# 
#-----[ OPEN ]------------------------------------------ 
# 
includes/functions_post.php

# 
#-----[ FIND ]------------------------------------------ 
#
// Check message
	if (!empty($message))
	{

# 
#-----[ REPLACE WITH ]------------------------------------------ 
#
// Check message
// $mode == 'editpost' added for Min-Maxlength Mod
	if (!empty($message) || $mode == 'editpost')
	{ 
  $message = trim($message);
  if ( (strlen ($message) > $board_config['message_maxlength']) && ($board_config['message_maxlength'] > 0) )
        {
            $message_too_long = sprintf($lang['Message_Maxlength_error'], $board_config['message_maxlength']);
            $error_msg .= (!empty($error_msg)) ? '<br />' . $message_too_long : $message_too_long;
        }
  if ( (strlen ($message) < $board_config['message_minlength']) && ($board_config['message_minlength'] > 0) )
        {
            $message_too_short = sprintf($lang['Message_Minlength_error'], $board_config['message_minlength']);
            $error_msg .= (!empty($error_msg)) ? '<br />' . $message_too_short : $message_too_short;
        }

# 
#-----[ OPEN ]------------------------------------------ 
# 
templates/subSilver/admin/board_config_body.tpl 

# 
#-----[ FIND ]------------------------------------------ 
# 
<tr>
		<td class="row1">{L_FLOOD_INTERVAL} <br /><span class="gensmall">{L_FLOOD_INTERVAL_EXPLAIN}</span></td>
		<td class="row2"><input class="post" type="text" size="3" maxlength="4" name="flood_interval" value="{FLOOD_INTERVAL}" /></td>
	</tr>

# 
#-----[ AFTER, ADD ]------------------------------------------ 
# 
  <tr> 
    <td class="row1">{L_MESSAGE_MINLENGTH} <br /><span class="gensmall">{L_MESSAGE_MINLENGTH_EXPLAIN}</span></td> 
    <td class="row2"><input class="post" type="text" size="3" maxlength="4" name="message_minlength" value="{MESSAGE_MINLENGTH}" /></td> 
  </tr>
<tr> 
    <td class="row1">{L_MESSAGE_MAXLENGTH} <br /><span class="gensmall">{L_MESSAGE_MAXLENGTH_EXPLAIN}</span></td> 
    <td class="row2"><input class="post" type="text" size="3" maxlength="4" name="message_maxlength" value="{MESSAGE_MAXLENGTH}" /></td> 
  </tr>

# 
#-----[ SAVE/CLOSE ALL FILES ]------------------------------------------ 
# 
# EoM

Luuk · Bericht door **Luuk** » 22 mei 2005, 20:19

Staat het er dan wel in? Misschien is het weggehaald. Het is dit stuk

Code: Selecteer alles

function checkForm() {

	formErrors = false;    

	if (document.post.message.value.length < 2) {
		formErrors = "{L_EMPTY_MESSAGE}";
	}

	if (formErrors) {
		alert(formErrors);
		return false;
	} else {
		bbstyle(-1);
		//formObj.preview.disabled = true;
		//formObj.submit.disabled = true;
		return true;
	}
}

Of in de <form..> tag staat niet onsubmit="return checkForm(this)".

Muiter · Bericht door **Muiter** » 02 jun 2005, 13:59

Luuk schreef:Staat het er dan wel in? Misschien is het weggehaald. Het is dit stuk
Of in de <form..> tag staat niet onsubmit="return checkForm(this)".

Staat er gewoon in.